Checksumming AppImage on build should work with internal python functions #2

New Issue

emiliano.vavassori · 2023-12-01T17:03:39Z

2023-12-01 17:03:39 +00:00

When building an AppImage, sometimes the script fails with:

Building fresh works fine and produces a working appimage even though it gives a traceback with this at the end:

File "/home/user/.local/pipx/venvs/loaih/lib/python3.11/site-packages/loaih/build.py", line 427, in __create_checksum__
   checksum = subprocess.run(f"md5sum {file}", shell=True,
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/subprocess.py", line 571, in run
   raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'md5sum LibreOffice-7.6.basic-x86_64.AppImage' returned non-zero exit status 1

The checksumming should be done with native functions instead of calling external binaries.

Thanks to buovjaga for reporting.

When building an AppImage, sometimes the script fails with: ``` Building fresh works fine and produces a working appimage even though it gives a traceback with this at the end: File "/home/user/.local/pipx/venvs/loaih/lib/python3.11/site-packages/loaih/build.py", line 427, in __create_checksum__ checksum = subprocess.run(f"md5sum {file}", shell=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command 'md5sum LibreOffice-7.6.basic-x86_64.AppImage' returned non-zero exit status 1 ``` The checksumming should be done with native functions instead of calling external binaries. Thanks to [buovjaga](https://www.reddit.com/user/buovjaga/) for reporting.

emiliano.vavassori commented

2023-12-01 21:57:07 +00:00

Should be fixed with commit 49e0ab5593.

Should be fixed with commit 49e0ab55934cc4c78e1742082001ca86bb527d04.

emiliano.vavassori closed this issue

2023-12-01 21:57:08 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: libreitalia/loaih#2